feat(hermes): add metrics #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
ali-bahjati
commented
Oct 17, 2023
| pub addr: SocketAddr, | ||
| #[arg(default_value = DEFAULT_RPC_LISTEN_ADDR)] | ||
| #[arg(env = "RPC_LISTEN_ADDR")] | ||
| pub listen_addr: SocketAddr, |
There was a problem hiding this comment.
these were not matching the cli args
ali-bahjati
force-pushed
the
hermes/add-metrics
branch
from
7c5f2ba to
61f72b0
Compare
ali-bahjati
commented
Oct 17, 2023
Comment on lines
-52
to
-66
| # Setup LibP2P. Unfortunately the dependencies required by libp2p are shared | ||
| # with the dependencies required by many Solana components. This means that we | ||
| # would have to use the same version of libp2p as solana. Luckily we don't need | ||
| # to worry about this until we want to hoist the libp2p portion of Hermes into | ||
| # Rust land. | ||
| libp2p = { version = "0.42.2", features = [ | ||
| "gossipsub", | ||
| "identify", | ||
| "mplex", | ||
| "noise", | ||
| "secp256k1", | ||
| "websocket", | ||
| "yamux", | ||
| ]} | ||
|
|
There was a problem hiding this comment.
Not used anymore
ali-bahjati
force-pushed
the
hermes/add-metrics
branch
from
61f72b0 to
0dd441e
Compare
Co-authored-by: Reisen <[email protected]>
ali-bahjati
force-pushed
the
hermes/add-metrics
branch
from
8260478 to
c6dbf60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.